Fix reading VB editor options from ISettingsManager (17.4) #66398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We regressed a few VB editor options in 17.4 (PR: dotnet#62759) when we switched reading these options from IVsTextManagerEvents4 to ISettingsManager API. - formatting: "Use Tabs", "Indent Size", "Tab Size". "Smart Indent", - statement completion: "Auto list members", "Hide advanced members", "Parameter information", - settings: "Navigation bar" We don't read their values for VS settings correctly for VB because we use language name "VisualBasic" while the editor uses "Basic" in the option storage name. This does not affect other languages (C#, F#).
tmat
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
@tmat in a separate PR, lets consider adding an integration test. With the vscode changes coming as well, this space will see a lot of churn. |
|
@arkalyanms We do have integration tests. They test setting and reading all options. If, however, the option storage name is wrong they will not fail because the settings manager is just gonna create a new option for that storage name with default value. The test will see what it expects to see. The planned changes shouldn't affect VS. |
|
This is not implemented in 17.4.5, right? |
|
@skurth No, it is not in 17.4 |
|
@skurth Indeed. |
Cosifne
added a commit
to Cosifne/roslyn
that referenced
this pull request
Apr 20, 2023
MSRC fix. According to the mail, we should update to 16.5.28. The feature branch is based on dotnet#66423 The last checked in bug fix is dotnet#66359 Since QB doesn't want to approve dotnet#66398 now. I feel we shouldn't wait for that change to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We regressed a few VB editor options in 17.4 (PR: #62759) when we switched reading these options from IVsTextManagerEvents4 to ISettingsManager API.
We don't read their values for VS settings correctly for VB because we use language name "VisualBasic" while the editor uses "Basic" in the option storage name.
This does not affect other languages (C#, F#).
Fixes #66325
VS issue: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1717717